Skip to content

stream: remove duplicated utility#63031

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:remove-duplicate-non-writable-util
Open

stream: remove duplicated utility#63031
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:remove-duplicate-non-writable-util

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 29, 2026

And reorder the object keys in ASCII-order (only a few were slightly off, couldn't help myself)

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (2a601eb) to head (d76d371).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63031      +/-   ##
==========================================
- Coverage   89.65%   89.64%   -0.02%     
==========================================
  Files         708      708              
  Lines      220374   220356      -18     
  Branches    42264    42262       -2     
==========================================
- Hits       197584   197539      -45     
- Misses      14656    14681      +25     
- Partials     8134     8136       +2     
Files with missing lines Coverage Δ
lib/internal/webstreams/queuingstrategies.js 100.00% <100.00%> (ø)
lib/internal/webstreams/readablestream.js 98.54% <100.00%> (-0.01%) ⬇️
lib/internal/webstreams/transformstream.js 98.55% <100.00%> (-0.02%) ⬇️
lib/internal/webstreams/util.js 99.57% <100.00%> (+0.01%) ⬆️
lib/internal/webstreams/writablestream.js 99.85% <100.00%> (-0.01%) ⬇️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants